feat(surveys): ff cross-sell with mini survey builder #41873

adboio · 2025-11-21T02:11:29Z

Problem

not many people click the create survey button from the feature flag sub-menus, and even fewer follow through to create a survey

i think this is because 1) the button is pretty hidden, and 2) the create-survey-with-AI workflow, as it exists today, is not very good

this PR introduces a new lightweight survey creation modal, embedded as "user feedback" within feature flags

Changes

survey-ff-cross-sell-demo2.mp4 (uploaded via Graphite)

new "quick create" survey modal. currently tailored towards feature flags (shows variants when available), but will be used for other products later
added a new "user feedback" section to feature flags that:
1. if no survey exists w/ this flag: shows the quick create
2. if 1 survey exists w/ this flag: shows the survey results
3. if >1 surveys exist w/ thsi flag: shows table of surveys

next steps:

make this a bit more useful with auto-summarization
bring it out to the actual ff detail page for better viz
use for other products like experiments

How did you test this code?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changelog: (features only) Is this feature complete?

adboio · 2025-11-21T02:11:50Z

feat(surveys): cross-sell with experiments #42171
feat(surveys): experiment with quickcreate modal on funnels #42158
feat(surveys): enhance ff cross-sell #41941
feat(surveys): ff cross-sell with mini survey builder #41873 👈 (View in Graphite)
feat(surveys): add cross-sell button to funnel insights #41703 : 1 other dependent PR (#41694 )
feat(surveys): add FK for linked_insight_id #41708
feat(surveys): add linked_insight_id field #41689
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-11-21T02:16:49Z

Size Change: +68 B (0%)

Total Size: 3.41 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	3.41 MB	+68 B (0%)

_{compressed-size-action}

posthog-bot · 2025-11-21T21:40:05Z

Visual regression: Storybook UI snapshots updated

Mode: UPDATE (triggered by human commit cc81a14)

Changes: 2 snapshots (2 modified, 0 added, 0 deleted)

What this means:

Snapshots have been automatically updated to match current rendering
Next CI run will switch to CHECK mode to verify stability
If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

Review the changes to ensure they're intentional
Approve if changes match your expectations
If unexpected, investigate component rendering

Review snapshot changes →

posthog-bot · 2025-11-21T22:17:57Z

Visual regression: Storybook UI snapshots updated

Mode: UPDATE (triggered by human commit 4273289)

Changes: 2 snapshots (2 modified, 0 added, 0 deleted)

What this means:

Snapshots have been automatically updated to match current rendering
Next CI run will switch to CHECK mode to verify stability
If snapshots change again, CHECK mode will fail (indicates flapping)

Next steps:

Review the changes to ensure they're intentional
Approve if changes match your expectations
If unexpected, investigate component rendering

Review snapshot changes →

greptile-apps

_{11 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

frontend/src/scenes/surveys/QuickSurveyModal.tsx

adboio · 2025-11-22T04:03:58Z

sorry for the monster, ~500 lines are just tests i promise

lucasheriques

couple of comments

frontend/src/scenes/surveys/QuickSurveyModal.tsx

graphite-app · 2025-11-25T19:45:28Z

Merge activity

Nov 25, 7:45 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
Nov 25, 7:45 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
Nov 26, 9:23 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
Nov 26, 9:23 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

This was referenced Nov 21, 2025

feat(surveys): add linked_insight_id field #41689

Merged

feat(surveys): create survey cross-sell opportunity logic #41694

Closed

feat(surveys): add cross-sell to funnel insights #41699

Closed

This was referenced Nov 21, 2025

feat(surveys): add FK for linked_insight_id #41708

Merged

feat(surveys): add cross-sell button to funnel insights #41703

Merged

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 2 times, most recently from 6f6b43d to dbc02e4 Compare November 21, 2025 16:26

adboio force-pushed the 11-18-feat_surveys_add_index branch 2 times, most recently from d25c4a7 to a08a5cd Compare November 21, 2025 16:27

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 2 times, most recently from 943b3c7 to 32e43dd Compare November 21, 2025 17:10

adboio force-pushed the 11-18-feat_surveys_add_index branch 2 times, most recently from a848bcc to 0fee956 Compare November 21, 2025 19:29

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 2 times, most recently from 989ba6f to cc81a14 Compare November 21, 2025 21:27

adboio force-pushed the 11-18-feat_surveys_add_index branch from 0fee956 to c640776 Compare November 21, 2025 21:27

adboio changed the base branch from 11-18-feat_surveys_add_index to graphite-base/41873 November 21, 2025 21:47

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch from 4d7b6c6 to 4273289 Compare November 21, 2025 22:05

adboio force-pushed the graphite-base/41873 branch from c640776 to 294b0a5 Compare November 21, 2025 22:05

adboio changed the base branch from graphite-base/41873 to master November 21, 2025 22:05

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 3 times, most recently from 5a038b2 to 8e43946 Compare November 22, 2025 02:38

adboio requested review from a team November 22, 2025 02:42

posthog-project-board-bot bot added this to Feature Flags Nov 22, 2025

posthog-project-board-bot bot moved this to Todo in Feature Flags Nov 22, 2025

adboio marked this pull request as ready for review November 22, 2025 02:50

posthog-project-board-bot bot moved this from Todo to In Review in Feature Flags Nov 22, 2025

greptile-apps bot reviewed Nov 22, 2025

View reviewed changes

frontend/src/scenes/surveys/QuickSurveyModal.tsx Outdated Show resolved Hide resolved

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch from 8e43946 to 61abcf2 Compare November 22, 2025 04:02

adboio mentioned this pull request Nov 22, 2025

feat(surveys): enhance ff cross-sell #41941

Open

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 2 times, most recently from dc5bc43 to b74ae2e Compare November 24, 2025 04:46

adboio enabled auto-merge (squash) November 24, 2025 05:32

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch 2 times, most recently from 042798e to 8049800 Compare November 24, 2025 23:55

lucasheriques reviewed Nov 25, 2025

View reviewed changes

frontend/src/scenes/surveys/QuickSurveyModal.tsx Outdated Show resolved Hide resolved

frontend/src/scenes/surveys/QuickSurveyModal.tsx Outdated Show resolved Hide resolved

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch from 8049800 to 8118691 Compare November 25, 2025 03:22

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch from 8118691 to 2127eb4 Compare November 26, 2025 01:29

adboio requested a review from lucasheriques November 26, 2025 02:09

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch from 2127eb4 to e97ceac Compare November 26, 2025 17:09

adboio and others added 2 commits November 26, 2025 11:23

feat(surveys): ff cross-sell with mini survey builder

4090716

test(storybook): update UI snapshots

d6d830e

adboio force-pushed the 11-20-feat_surveys_ff_cross-sell_with_mini_survey_builder branch from e97ceac to d6d830e Compare November 26, 2025 19:23

This was referenced Nov 26, 2025

feat(surveys): experiment with quickcreate modal on funnels #42158

Draft

feat(surveys): cross-sell with experiments #42171

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(surveys): ff cross-sell with mini survey builder #41873

feat(surveys): ff cross-sell with mini survey builder #41873

adboio commented Nov 21, 2025 •

edited

Loading

Uh oh!

adboio commented Nov 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

posthog-bot commented Nov 21, 2025

Uh oh!

posthog-bot commented Nov 21, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

adboio commented Nov 22, 2025

Uh oh!

lucasheriques left a comment

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Nov 25, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(surveys): ff cross-sell with mini survey builder #41873

Are you sure you want to change the base?

feat(surveys): ff cross-sell with mini survey builder #41873

Conversation

adboio commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this code?

Changelog: (features only) Is this feature complete?

Uh oh!

adboio commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

posthog-bot commented Nov 21, 2025

Visual regression: Storybook UI snapshots updated

Uh oh!

posthog-bot commented Nov 21, 2025

Visual regression: Storybook UI snapshots updated

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adboio commented Nov 22, 2025

Uh oh!

lucasheriques left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adboio commented Nov 21, 2025 •

edited

Loading

adboio commented Nov 21, 2025 •

edited

Loading

github-actions bot commented Nov 21, 2025 •

edited

Loading

graphite-app bot commented Nov 25, 2025 •

edited

Loading